Reduce the ordering difference with respect to Glyphs #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
approved these changes
Feb 23, 2023
|
LGTM (pending tests fixups) |
|
I have updated the tests. It is important to emphasize that, since there is no documentation for such things, it was inferred manually based on a number of typefaces (Mark Simonson's collection was used). There could be cases that have not been seen yet but would lead to further refinement of the ordering. To be continued, in other words. (In general, there are other deviations that are not related to ordering. The most common ones are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
glyphsLibfor manipulating Glyphs files, it produces a lot of unrelated changes due to its serialization order that is different from the one used by Glyphs. This PR is an attempt to reduce the different.