Serialize instance properties #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have confirmed that this preserves instance properties. The error below is arguably unrelated to the cahnge. |
|
@IvanUkhov codecov flakiness is unrelated (see codecov/feedback#126), right now we can only either keep retrying until the upload of the coverage file is successful or just ignore it.. I'll take a look at the PR, thanks |
nice. If it's not too much trouble, mind adding a small test? |
|
@anthrotype, I have added a test. Please take a look. |
anthrotype
reviewed
Feb 23, 2023
anthrotype
approved these changes
Feb 23, 2023
|
The new failure is again unrelated. Would you be able to re-run? |
|
I'll just merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes codecov/codecov-action#861.