VF settings fixup for #812/#813 #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Oct 6, 2022
Lib/glyphsLib/classes.py
Outdated
| @@ -141,6 +141,9 @@ | |||
| OFFCURVE = "offcurve" | |||
| QCURVE = "qcurve" | |||
|
|
|||
| INSTANCETYPESINGLE = 0 | |||
| INSTANCETYPEVARIABLE = 1 | |||
There was a problem hiding this comment.
should this be defined in https://github.com/googlefonts/glyphsLib/blob/main/Lib/glyphsLib/builder/constants.py maybe? The same probably applies for the other constants defined in here, at least those that are imported by other modules and not private to the current one.
There was a problem hiding this comment.
Moving it there leads to circular imports. It's not immediately obvious to me how to avoid that ...
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixup for #812 and #813.