hints: target="up" or "down" #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@madig do we need to check target="down" or target="up" only occurs with type="TopGhost" or "BottomGhost" respectively? |
moyogo
force-pushed
the
hints-target-up-down
branch
from
7e8a337 to
c91b124
Compare
|
No idea. @schriftgestalt ? |
This is true. Is this answering the question? |
moyogo
force-pushed
the
hints-target-up-down
branch
from
c91b124 to
af15d6a
Compare
Yes, thanks! I guess glyphsLib doesn’t need to validate. |
moyogo
force-pushed
the
hints-target-up-down
branch
2 times, most recently
from
b611620 to
cc5d43a
Compare
anthrotype
reviewed
Sep 21, 2020
| if attr in hint: | ||
| value = Point(*hint[attr]) | ||
| # handle target = ['u', 'p'] or ['d', 'o', 'w', 'n'] |
There was a problem hiding this comment.
@moyogo why do we need to handle target = ['u', 'p'] or ['d', 'o', 'w', 'n'] ? Is that for backward compat with how these attribute was written out to UFO before this PR? If so, maybe add a comment with a link to the issue
moyogo
force-pushed
the
hints-target-up-down
branch
from
cc5d43a to
568ee04
Compare
Added a glyph to GlyphsUnitTestSans thus changing indeces of glyphs that follow.
moyogo
force-pushed
the
hints-target-up-down
branch
from
568ee04 to
a82c2ad
Compare
anthrotype
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Hints: handle up and down targets #376