Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept os.PathLike objects in GSFont.__init__ #359

Merged
merged 3 commits into from
May 15, 2018
Merged

Accept os.PathLike objects in GSFont.__init__ #359

merged 3 commits into from
May 15, 2018

Conversation

madig
Copy link
Collaborator

@madig madig commented May 10, 2018

So you can pass in Path and friends.

@anthrotype
Copy link
Member

anthrotype commented May 10, 2018 •
edited
Loading

got a test?
of course, it should do @pytest.mark.skipif(sys.version_info < (3,4)

@madig
Copy link
Collaborator Author

madig commented May 10, 2018

Once we drop Python < 3.6, a better solution might be to copy the approach of the 3.6 stdlib: https://github.com/python/cpython/blob/a6a4dc816d68df04a7d592e0b6af8c7ecc4d4344/Lib/bz2.py#L91

@madig
Copy link
Collaborator Author

madig commented May 15, 2018

Anything missing?

@anthrotype
Copy link
Member

I already approved, you can do the merge, no?

@madig
Copy link
Collaborator Author

madig commented May 15, 2018

I see no merge button :O

@belluzj belluzj merged commit 06779fd into googlefonts:master May 15, 2018
@anthrotype
Copy link
Member

I see no merge button :O

@madig sorry, I now added you as collaborator

@madig madig deleted the accept-pathlike-objects branch May 15, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madig @anthrotype @belluzj