[IFT] Add code gen definitions for GlyphKeyed patches #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
Oct 10, 2024
| #[count($glyph_count)] | ||
| #[read_with($flags)] | ||
| #[traverse_with(skip)] | ||
| #[compile(skip)] // TODO remove this once write fonts side is implemented. |
There was a problem hiding this comment.
are we trying to compile this table? If not maybe it makes more sense to skip the whole table, instead of generating write-fonts code that is going to be incorrect. You can add #[skip_font_write] to skip just this table, although it might also break other tables that reference it..
There was a problem hiding this comment.
In this first pass I'm not going to implement compilation, but I will be adding eventually. So far I've just been using #[compile(skip)] on anything that causes any issues with the plan being to go back and fix it all up once I get to implementing compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second patch format for IFT, see: https://w3c.github.io/IFT/Overview.html#glyph-keyed