Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add alternate transform representation in PaintTransformed #113

Merged
merged 9 commits into from
Nov 24, 2020
Merged

add alternate transform representation in PaintTransformed #113

merged 9 commits into from
Nov 24, 2020

Conversation

PeterConstable
Copy link
Collaborator

Per #88

anthrotype
anthrotype reviewed Nov 13, 2020
View reviewed changes
anthrotype
anthrotype reviewed Nov 13, 2020
View reviewed changes
@rsheeter
Copy link
Contributor

rsheeter commented Nov 13, 2020 •
edited
Loading

As noted on #88 IMHO we should do a new Paint with one field: angle. Skew and scale and so on are best represented by PaintTransformed; you can Rotate>PaintTransformed (and vice versa) if you need both.

Edit: now I understand why we wanted skew (see #88)

@PeterConstable PeterConstable mentioned this pull request Nov 13, 2020
Open
rsheeter
rsheeter reviewed Nov 13, 2020
View reviewed changes
anthrotype
anthrotype reviewed Nov 13, 2020
View reviewed changes
rsheeter
rsheeter reviewed Nov 13, 2020
View reviewed changes
@rsheeter
Copy link
Contributor

I'm very sleepy but this lgtm. @anthrotype wdyt?

anthrotype
anthrotype reviewed Nov 13, 2020
View reviewed changes
@PeterConstable PeterConstable force-pushed the petercon/transformparam branch from 3941503 to 672a0da Compare November 14, 2020 01:20
@PeterConstable PeterConstable force-pushed the petercon/transformparam branch from 672a0da to 9b4c446 Compare November 23, 2020 23:43
drott
drott reviewed Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@drott drott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, a few suggested edits to update to latest naming.

colr-gradients-spec.md Outdated
| Type | Field name | Description |
|-|-|-|
| uint8 | format | Set to 9. |
| Offset24 | paintOffset | Offset to a Paint subtable, from start of PaintRotateSkew table. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Offset24 | paintOffset | Offset to a Paint subtable, from start of PaintRotateSkew table. |
| Offset24 | paintOffset | Offset to a Paint subtable, from start of PaintSkew table. |

colr-gradients-spec.md Outdated
| Offset24 | paintOffset | Offset to a Paint subtable, from start of PaintRotateSkew table. |
| VarFixed | xSkewAngle | Angle of skew in the direction of the x-axis, in counter-clockwise degrees. |
| VarFixed | ySkewAngle | Angle of skew in the direction of the y-axis, in counter-clockwise degrees. |
| VarFixed | centerX | x coordinate for the center of rotation. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| VarFixed | centerX | x coordinate for the center of rotation. |
| VarFixed | centerX | x coordinate for the center of skew. |

colr-gradients-spec.md Outdated
| VarFixed | xSkewAngle | Angle of skew in the direction of the x-axis, in counter-clockwise degrees. |
| VarFixed | ySkewAngle | Angle of skew in the direction of the y-axis, in counter-clockwise degrees. |
| VarFixed | centerX | x coordinate for the center of rotation. |
| VarFixed | centerY | y coordinate for the center of rotation. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| VarFixed | centerY | y coordinate for the center of rotation. |
| VarFixed | centerY | y coordinate for the center of skew. |

@google-cla
Copy link

google-cla bot commented Nov 24, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Nov 24, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@PeterConstable PeterConstable force-pushed the petercon/transformparam branch from e458f5b to 5a7f441 Compare November 24, 2020 16:42
@drott
Copy link
Collaborator

drott commented Nov 24, 2020

@googlebot I fixed it.

@drott drott merged commit 09657b3 into googlefonts:master Nov 24, 2020
@rsheeter rsheeter mentioned this pull request Nov 24, 2020
Closed
@PeterConstable PeterConstable deleted the petercon/transformparam branch November 24, 2020 18:02
@rsheeter rsheeter mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lorp Lorp Lorp left review comments

@rsheeter rsheeter rsheeter approved these changes

@anthrotype anthrotype anthrotype left review comments

@drott drott drott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PeterConstable @rsheeter @drott @Lorp @anthrotype