This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Upgrade google.cloud.monitoring #702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebrahim
previously approved these changes
Aug 14, 2018
rajivpb
previously approved these changes
Aug 14, 2018
rajivpb
previously approved these changes
Aug 15, 2018
…ecause it seems the google.cloud.monitoring library made a significant change from a single Client class to a series of smaller ServiceClients, and our code seems to assume we have a single object with the functionality of multiple of these ServiceClients in various places.
rileyjbauer
requested review from
yebrahim
and removed request for
ojarjur and
yebrahim
yebrahim
approved these changes
Aug 17, 2018
| # it has now been broken up into multiple subclients. Most | ||
| # of the usages I found aligned with the MetricServiceClient, | ||
| # but other uses, such as those in group_tests.py, require a | ||
| # GroupServiceClient, and there are potentially others. |
There was a problem hiding this comment.
I'm not sure I understand this comment. If we're not importing GroupServiceClient, what does the comment add?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See relevant
google-cloud-pythonrepo directory:https://github.com/GoogleCloudPlatform/google-cloud-python/tree/master/monitoring/google/cloud
This should address the build failures that were blocking #700