Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .bazelrc to be compatible with Bazel 0.23.0 #1

Closed
wants to merge 1 commit into from
Closed

Fix .bazelrc to be compatible with Bazel 0.23.0 #1

wants to merge 1 commit into from

Conversation

philwo
Copy link

@philwo philwo commented Feb 6, 2019

The two flags --incompatible_remove_native_http_archive and --incompatible_remove_native_git_repository have been enabled by default in a recent release and were subsequently removed, so specifying them in Bazel 0.23.0 will result in an error due to the flags being unknown.

We can just remove them from the .bazelrc now.

The two flags --incompatible_remove_native_http_archive and --incompatible_remove_native_git_repository have been enabled by default in a recent release and were subsequently removed, so specifying them in Bazel 0.23.0 will result in an error due to the flags being unknown.

We can just remove them from the .bazelrc now.
@philwo
Copy link
Author

philwo commented Feb 6, 2019

FYI @ensonic

@ensonic
Copy link
Contributor

ensonic commented Feb 6, 2019

recent release

Do you remember which one, so that we can tell people to use e.g. >=0.20.0

@philwo
Copy link
Author

philwo commented Feb 6, 2019

Yes, according to our issue tracker and release notes, the flags were flipped in 0.20.0:

bazelbuild/bazel#6569
bazelbuild/bazel#6570

However, AFAIK it shouldn't really matter - load()'ing the new http_* rules doesn't depend on manually flipping these flags. The --incompatible_* flags are just intended to identify breakages in advance on CI and "should" never be deployed to production or routinely used by developers (although I'm not sure if that's a soft or hard rule, @dslomov should be able to clarify). :)

By the way, not sure if it's interesting for you, but https://github.com/philwo/bazelisk is a helpful wrapper for Bazel, if you often have people building your project who might not have (the correct version of) Bazel installed. You can check it into your repo together with a .bazelversion file and it will automatically download and run the matching official release of Bazel for the user's platform.

@dslomov
Copy link

dslomov commented Feb 6, 2019

We do not recommend running production builds with --incompatible_* or --experimental_* flags (which implies not putting them into checked-in .bazelrcs). We can and will remove these flags at random times.
Please check out our full breaking change policy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants