Skip to content
This repository has been archived by the owner on Dec 6, 2018. It is now read-only.

Eliminates global uglify-js dependency in favour of local #180

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

niksumeiko
Copy link
Contributor

After cloning a fresh copy of the project, installing npm dependencies and running npm run build, there's an error thrown.

sh: uglifyjs: command not found
events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at exports._errnoException (util.js:1026:11)
    at WriteWrap.afterWrite [as oncomplete] (net.js:848:14)

Error appears, because project requires uglify-js to be installed globally.

I think, it would be better if we try to avoid relying on global dependencies where possible. This PR does just that — it eliminates global uglify-js dependency in favour of local.

@lincolnfrog lincolnfrog merged commit 2c416c2 into googlearchive:master Jun 19, 2017
@niksumeiko niksumeiko deleted the hotfix/local-uglify-js branch June 19, 2017 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants