This repository has been archived by the owner on Dec 6, 2018. It is now read-only.
Fixed structure of timeupdate event and typo on volumechange event
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lincolnfrog Ready. This should be good now. Let me know otherwise |
|
I don't know why the test is failing. Is it something on my side? |
|
There is some issue with the CI settings that i will work on getting resolved. Everything is failing now, its not your fault. |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, timeupdate event is broken, and following the HTML5 conventions of the event (https://msdn.microsoft.com/en-us/library/ff974185(v=vs.85).aspx), it should return currentTime and duration. And volumechange was emitting the wrong event. This PR fixed those issues. This is the fixed version of PR #171