-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use GitHub .gitignore template for Node.js #126
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include all the ignores that are already in .gitignore in addition to adding these new entries.
Includes googlevr/vrview initial ignores
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@googlebot, I confirm I'm okay my commits are contributed to this project. Actually that was the purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niksumeiko I have merged your changes, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lincolnfrog we followed your request!
@lincolnfrog, @yvan-sraka, I know PR is already merged and closed, but I wished to discuss with you, what we do with From official documentation:
Currently, it's not listed in What do you guys think? |
No description provided.