Skip to content
This repository has been archived by the owner on Dec 6, 2018. It is now read-only.

Use GitHub .gitignore template for Node.js #126

Merged
merged 5 commits into from
Jun 15, 2017

Conversation

yvan-sraka
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@yvan-sraka
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@lincolnfrog lincolnfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include all the ignores that are already in .gitignore in addition to adding these new entries.

Includes googlevr/vrview initial ignores
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@niksumeiko
Copy link
Contributor

@googlebot, I confirm I'm okay my commits are contributed to this project. Actually that was the purpose.

Copy link
Contributor Author

@yvan-sraka yvan-sraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niksumeiko I have merged your changes, thanks!

Copy link
Contributor Author

@yvan-sraka yvan-sraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lincolnfrog we followed your request!

@lincolnfrog lincolnfrog merged commit 2393adf into googlearchive:master Jun 15, 2017
@yvan-sraka yvan-sraka deleted the patch-0 branch June 16, 2017 07:18
@niksumeiko
Copy link
Contributor

@lincolnfrog, @yvan-sraka, I know PR is already merged and closed, but I wished to discuss with you, what we do with package-lock.json?

From official documentation:

This file is automatically generated for any operations where npm modifies either the node_modules/ tree, or package.json. This file is intended to be committed into source repositories.

Currently, it's not listed in .gitignore and shan't be, I think. So anyone actually can commit/push this file any time…

What do you guys think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants