This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Update instructions for newbies like me to contribute. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the packages.json file is missing mocha and chai so these instructions don't strictly work right now on master branch. But it looks like this is fixed in stable and just needs to be pulled back down to master. |
|
This is a great update! I'll let @azakus do the merging for our next push. Otherwise, LGTM. |
dfreedm
added a commit
that referenced
this pull request
Aug 6, 2013
Update instructions for newbies like me to contribute.
|
Merging in then :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had attempted the follow the CONTRIBUTING.md file, but failed to get the tests running. Luckily someone answered my question very quickly #13 , but I think it would save other newbies time and effort if the CONTRIBUTING.md file included the steps to pull down polymer-all and install the node modules.