This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Remove replacing apostrophes with double apostrophes before trying to parse string to JSON #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying to parse string to JSON
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example let's have JSON
{"test" : "it's perfectly valid JSON"}
And then you plug this JSON to your element's published property attribute, the parsing will fail due to replace which is being done right now.
I think it's reasonable to remove this replace and allow only valid (http://json.org/) JSON to be parsed.
By the way if you realize what are the implications of this replacing you'll find the comment saying: " // include convenience replace for single-quotes. If the author omits" very funny.