This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Feature request: detect styles which are not defined in template #132

Open

naoak opened this issue Jun 2, 2016 · 0 comments

naoak commented Jun 2, 2016

Related to Polymer/polymer/issues/3665.

Styles which are not defined in template causes style leaks in some cases. So I desire the feature to detect those bad manner elements.

naoak mentioned this issue

Add feature to detect style leaks #133

Open

ankon added a commit to Collaborne/paper-alert-dialog that referenced this issue


          Move the <style> into the <template>

b422523

Having the CSS outside of the template makes polymer/webcomponents? insert the style without
any scoping into the final document, which can cause style leakage.

Polymer 1.x deprecated this already:
> Prior to Polymer 1.1, the recommendation was to place <style> tags inside the <dom-module> for an element (but outside the <template>). This is still supported, but is no longer recommended.
(https://www.polymer-project.org/1.0/docs/devguide/styling)

Polymer 2.0 will no longer support this according to https://www.polymer-project.org/2.0/docs/upgrade#dom-template.

See also: Polymer/polymer#3665
See also: googlearchive/polylint#132

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.