This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
manual-change event #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added JSDoc for the `manual-change` event and fire it in the code when `value` changes due to manual interaction.
| @@ -271,10 +283,12 @@ | |||
|
|
|||
| increment: function() { | |||
| this.value = this.clampValue(this.value + this.step); | |||
| this.fire('manual-change'); | |||
There was a problem hiding this comment.
I think is better to move this to keydown() so if someone invokes increment()/decrement() manually the event will not be fired.
…instead of in increment/decrement.
| @@ -287,6 +299,7 @@ | |||
| } else if (c === 39) { | |||
| this.increment(); | |||
| } | |||
| this.fire('manual-change'); | |||
There was a problem hiding this comment.
Sorry for not being clear previously, but It should fire only when increment/decrement is called. e.g.
if (c === 37) {
this.decrement();
this.fire('manual-change');
} else if (c === 39) {
this.increment();
this.fire('manual-change');
}
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JSDoc for the
manual-changeevent and fire it in the code whenvaluechanges due to manual interaction.See #7 for context.