This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Fix tap highlight issue on paper-icon-button #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screenshot of current behavior of paper-icon-button: http://i.imgur.com/Hsl856m.png The UA adds an ugly square around the button when pressed to 'give faster feedback'. Since we have the ripples this is unnecessary. It is disabled on Blink and Webkit with -webkit-tap-highlight-color: rgba(0,0,0,0); There is currently no solution for Mozilla and IE's fix requires a metatag which I'm not sure how to do in a way that fits into the web components approach.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
I am a Google employee. I have also signed the CLA just to be safe. |
|
CLAs look good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot of current broken behavior of paper-icon-button: http://i.imgur.com/Hsl856m.png
The UA adds an ugly square around the button when pressed to 'give faster touch feedback'. Since we have the ripples this is unnecessary. It is disabled on Blink and Webkit with -webkit-tap-highlight-color: rgba(0,0,0,0);
There is currently no solution for Mozilla and IE's fix requires a metatag which I'm not sure how to do in a way that fits into the web components approach.