Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

tests should be mostly async #42

Open
rafaelw opened this issue Jan 16, 2014 · 2 comments
Open

tests should be mostly async #42

rafaelw opened this issue Jan 16, 2014 · 2 comments
Assignees
@rafaelw

Comments

@rafaelw
Copy link
Contributor

rafaelw commented Jan 16, 2014

especially for Object.observe, async is the normal case (not forced deliver)
rafaelw added a commit that referenced this issue Jan 16, 2014
@rafaelw
ensure that observedSet resets observed objects after changes
0152d54 
this was a pretty major oversight on my part, and unfortunately, the tests are structure such that the "organic" callback of Object.observe is never depended upon.

What really needs to be done here is to make most of the tests be async using the then() pattern, but this bug is blocking polymer release, so I'm going to do that work in a follow-on patch.

#42
R=arv
BUG=

Review URL: https://codereview.appspot.com/53490043
@jmesserly
Copy link
Contributor

Happy to help with this too ... I'm guessing similar refactoring here as was done to the template binding tests?

@jmesserly
Copy link
Contributor

.... although presumably some (fraction of?) tests should stay using .deliver?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rafaelw rafaelw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaelw @jmesserly