put Path.isValid back

Reverted: googlearchive/polymer-expressions@4a4a45a R=arv BUG= Review URL: https://codereview.appspot.com/13498044
googlearchive · Sep 3, 2013 · cf35308 · cf35308
1 parent 4190641
commit cf35308
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 15 deletions.
diff --git a/src/observe.js b/src/observe.js
@@ -1309,4 +1309,9 @@
   global.PathObserver = PathObserver;
   global.CompoundPathObserver = CompoundPathObserver;
   global.Path = Path;
+
+  global.Path.isValid = function(pathString) {
+    return Path.get(pathString) !== undefined;
+  };
+
 })(typeof global !== 'undefined' && global ? global : this);
diff --git a/tests/test.js b/tests/test.js
@@ -75,24 +75,24 @@ suite('Path', function() {
   });
 
   test('valid paths', function() {
-    assert.isDefined(Path.get('a'));
-    assert.isDefined(Path.get('a.b'));
-    assert.isDefined(Path.get('a. b'));
-    assert.isDefined(Path.get('a .b'));
-    assert.isDefined(Path.get('a . b'));
-    assert.isDefined(Path.get(''));
-    assert.isDefined(Path.get(' '));
-    assert.isDefined(Path.get(null));
-    assert.isDefined(Path.get(undefined));
-    assert.isDefined(Path.get());
-    assert.isDefined(Path.get(42));
+    assert.isTrue(Path.isValid('a'));
+    assert.isTrue(Path.isValid('a.b'));
+    assert.isTrue(Path.isValid('a. b'));
+    assert.isTrue(Path.isValid('a .b'));
+    assert.isTrue(Path.isValid('a . b'));
+    assert.isTrue(Path.isValid(''));
+    assert.isTrue(Path.isValid(' '));
+    assert.isTrue(Path.isValid(null));
+    assert.isTrue(Path.isValid(undefined));
+    assert.isTrue(Path.isValid());
+    assert.isTrue(Path.isValid(42));
   });
 
   test('invalid paths', function() {
-    assert.isUndefined(Path.get('a b'));
-    assert.isUndefined(Path.get('.'));
-    assert.isUndefined(Path.get(' . '));
-    assert.isUndefined(Path.get('..'));
+    assert.isFalse(Path.isValid('a b'));
+    assert.isFalse(Path.isValid('.'));
+    assert.isFalse(Path.isValid(' . '));
+    assert.isFalse(Path.isValid('..'));
   });
 
   test('Paths are interned', function() {