This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
fix closeQuery to only close itself #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.query.off(); called with no parameters closes all Firebase listeners at that location. It should instead be called with the original eventType, callback and context passed in.
|
I submitted a Google Corporate CLA this morning. Not sure how long they take to process! |
mbleigh
added a commit
to mbleigh/firebase-element
that referenced
this pull request
Jan 25, 2015
kevinpschaaf
added a commit
that referenced
this pull request
Feb 2, 2015
fix closeQuery to only close itself
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If you have two webcomponents on the same page, each with a firebase-element listening to the same path, when one is removed, it will shutdown the listeners on the other.
Solution:
this.query.off();called with no parameters closes all Firebase listeners at that location. It should instead be called with the original eventType, callback and context passed in. (https://www.firebase.com/docs/web/api/query/off.html).Additional Mess:
Unfortunately an additional bug in Firebase (firebase/firebase-bower#6) means that until both bugs are fixed, the symptoms above will still exist. Firebase should compare the contexts to know that two listeners are different, but doesn't do that for the ChildEvent Listeners.