This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Documentation for attributes #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Attributes moved to a publish block * tallMode -> condenses, minHeaderHeight -> condensedHeaderHeight
|
Thanks for the docs! cc @frankiefu to take a look on the API changes. |
|
Yeah I like the suggestions. Thanks for the docs. |
|
@frankiefu has been busy. It looks like this will need rebasing |
|
merged in here: dcad5de |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interaction between
tallModeandminHeaderHeightwas a bit confusing - what do you think about renaming them tocondensesandcondensedHeaderHeight?Otherwise, here's some quick documentation; I think this follows the latest style you folk are using for attribute docs?