This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Add nameChanged handler #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `nameChanged` handler leads to the expected behavior if the `name` attribute changes, in that it will attempt to load the `value` corresponding to the `localStorage` cache with the key `name`.
|
@frankiefu PTAL when you get a chance :) |
|
lgtm |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nameChangedhandler leads to the expected behavior if thenameattribute changes, in that it will attempt to load thevaluecorresponding to thelocalStoragecache with the keyname.Since
nameChangedis fired when thenameattribute is initially set, it shouldn't be necessary to callloadwithin theattachedhandler anymore. (At least I don't think it is.)