Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

wrong close tag #8

Merged
merged 1 commit into from
Jul 23, 2014
Merged

wrong close tag #8

merged 1 commit into from
Jul 23, 2014

Conversation

frunjik
Copy link
Contributor

@frunjik frunjik commented Jul 20, 2014

the tag of the custom element is wrong (confused me :))
[my frst github change ever ...]

the tag of the custom element is wrong (confused me :))
[my frst github change ever ...]
@ebidel
Copy link
Contributor

ebidel commented Jul 21, 2014

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

@frunjik frunjik added cla: no and removed cla: yes labels Jul 21, 2014
@frunjik
Copy link
Contributor Author

frunjik commented Jul 22, 2014

thx,
did

2014-07-22 0:13 GMT+02:00 Eric Bidelman [email protected]:

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING
http://polymer.github.io/CONTRIBUTORS.txt guide.


Reply to this email directly or view it on GitHub
#8 (comment).

@ebidel
Copy link
Contributor

ebidel commented Jul 22, 2014

Thanks for signing the CLA!

@frunjik frunjik removed the cla: no label Jul 22, 2014
@frunjik
Copy link
Contributor Author

frunjik commented Jul 23, 2014

Eric sorry to disturb you (and a late happy birthday).

Do i have to do something now ?
I was not aware that the whole thing would be cloned for one slash - i
dont want to put u to work :)

I love polymer :)
But i am a bit lost in it and github :)
Can you tell me what is the best place to ask (newbie!!) questions ?
Thx

-J

2014-07-23 0:54 GMT+02:00 Eric Bidelman [email protected]:

Thanks for signing the CLA!


Reply to this email directly or view it on GitHub
#8 (comment).

@ebidel
Copy link
Contributor

ebidel commented Jul 23, 2014

Thanks :) Just waiting for someone to review. This LGTM. Thanks for submitting it.

ebidel added a commit that referenced this pull request Jul 23, 2014
@ebidel ebidel merged commit 3c5299c into googlearchive:master Jul 23, 2014
@sjmiles
Copy link
Contributor

sjmiles commented Jul 23, 2014

core-layout is deprecated.

On Wed, Jul 23, 2014 at 8:41 AM, Eric Bidelman [email protected]
wrote:

Merged #8 #8.


Reply to this email directly or view it on GitHub
#8 (comment).

@frunjik
Copy link
Contributor Author

frunjik commented Jul 23, 2014

What is is replaced with ?

2014-07-23 19:57 GMT+02:00 Scott J. Miles [email protected]:

core-layout is deprecated.

On Wed, Jul 23, 2014 at 8:41 AM, Eric Bidelman [email protected]
wrote:

Merged #8 #8.


Reply to this email directly or view it on GitHub
#8 (comment).


Reply to this email directly or view it on GitHub
#8 (comment).

@frunjik frunjik deleted the patch-1 branch July 23, 2014 20:43
@ebidel
Copy link
Contributor

ebidel commented Jul 23, 2014

@frunjik
Copy link
Contributor Author

frunjik commented Jul 30, 2014

Eric, sorry to disturb you again.
I did another miniscule commit, and i get the request to sign CLA again...
What do i need to not get that everytime ??
Thanx for your (precious time)

PewPolyPower!

2014-07-23 0:54 GMT+02:00 Eric Bidelman [email protected]:

Thanks for signing the CLA!


Reply to this email directly or view it on GitHub
#8 (comment).

@robdodson
Copy link

The CLA bot is a little crazy. If you've signed the CLA once and gotten the
'thanks for signing!' message then you should be all set

On Wed, Jul 30, 2014 at 2:15 AM, frunjik [email protected] wrote:

Eric, sorry to disturb you again.
I did another miniscule commit, and i get the request to sign CLA again...
What do i need to not get that everytime ??
Thanx for your (precious time)

PewPolyPower!

2014-07-23 0:54 GMT+02:00 Eric Bidelman [email protected]:

Thanks for signing the CLA!


Reply to this email directly or view it on GitHub
#8 (comment).


Reply to this email directly or view it on GitHub
#8 (comment).

@ebidel
Copy link
Contributor

ebidel commented Jul 30, 2014

Where was that commit?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants