Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Handle dynamic updates to mode property #11

Closed
ebidel opened this issue Aug 30, 2014 · 2 comments
Closed

Handle dynamic updates to mode property #11

ebidel opened this issue Aug 30, 2014 · 2 comments

Comments

@ebidel
Copy link
Contributor

ebidel commented Aug 30, 2014

From http://stackoverflow.com/questions/25585929/panel-setattributemode-waterfall/25586138

One example is that core-header-panel adds a tall class to a child with the class core-header:

waterfall-tall

If mode is updated later on to mode = 'waterfall', the tall class sticks around. core-header-panel should do this cleanup.

@gertcuykens
Copy link

Would be great if you make it small again using a slide effect when doing the cleanup :) The same effect as when you scroll down.

frankiefu added a commit that referenced this issue Sep 2, 2014
@frankiefu
Copy link
Contributor

fixed by 29650b6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants