This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Reformatted the type info displayed for method and event parameters #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like what you've done. Should we do it everywhere there's type information? Fix up attributes and properties too to be this new format? |
|
Okay, you can see what that looks like for attributes/properties at http://jeffposnick.github.io/core-doc-viewer/components/core-doc-viewer/demo.html#core-doc-viewer.attributes The |
|
Can we keep the same formatting as before, but just use |
|
PTAL. Changes are reflected at http://jeffposnick.github.io/core-doc-viewer/components/core-doc-viewer/demo.html#core-doc-viewer.attributes |
|
LGTM |
ebidel
added a commit
that referenced
this pull request
Sep 30, 2014
Reformatted the type info displayed for method and event parameters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ebidel @addyosmani
Closes #27, with a live example at http://jeffposnick.github.io/core-doc-viewer/components/core-doc-viewer/demo.html#core-xhr.methods.request (and that link makes use of support for intra-page URL fragments!).
I'm happy to switch up the formatting, if you have any strong preferences re: wrapping the type in
<>vs. something else, using<em>, etc.