Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Add support @property. Fixes #3 #10

Merged
merged 4 commits into from
May 13, 2014
Merged

Add support @property. Fixes #3 #10

merged 4 commits into from
May 13, 2014

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented May 8, 2014

For properties not exposed as attributes (published properties), this differentiates. Otherwise, it's confusing that everything is listed as an attribute. Users will expect they can configure that property as declaratively using its attribute.

Reviewer: @sjmiles

screen shot 2014-05-07 at 9 48 06 pm

I didn't touch the compiled core-component-page

ebidel added 2 commits May 7, 2014 21:43
For properties not exposed as attributes, this differentiates
@ebidel ebidel added cla: yes and removed cla: no labels May 8, 2014
@dfreedm
Copy link
Contributor

dfreedm commented May 13, 2014

LGTM

dfreedm added a commit that referenced this pull request May 13, 2014
@dfreedm dfreedm merged commit 08a1c67 into master May 13, 2014
@ebidel ebidel deleted the addprop branch May 14, 2014 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants