Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Remove bad status check in isSuccess #60

Merged
merged 1 commit into from
Jan 24, 2015

Conversation

bearfriend
Copy link
Contributor

See #58

The return statement that I modified seems like it shouldn't be necessary to be any more complicated than the one step that I left. The !status was causing any status equal to 0 to return true.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@bearfriend
Copy link
Contributor Author

Signed!

@googlebot
Copy link

CLAs look good, thanks!

@addyosmani
Copy link
Contributor

Change LGTM - we're dropping that !0 issue that was evaluating to true. cc @garlicnation in case this needs to be backed out.

addyosmani added a commit that referenced this pull request Jan 24, 2015
Remove bad status check in isSuccess
@addyosmani addyosmani merged commit 732fde9 into googlearchive:master Jan 24, 2015
@garlicnation
Copy link
Contributor

Thanks addy!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants