This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Add support for /deep/ to querySelector and querySelectorAll #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! out of curiosity, what wa the story behind the skipped tests? |
|
The skipped tests are due to the way we filter query results instead of walking the logical dom. With the filtering approach we fail when the element is not part of the composed tree. I realized that we did not need to skip the entire tests and some of the skips were fixed in a follow up pr. |
arv
added a commit
that referenced
this pull request
Aug 14, 2014
Add support for /deep/ to querySelector and querySelectorAll
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436