Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Fix issue with DOMTokenList #448

Merged
merged 1 commit into from
May 30, 2014
Merged

Conversation

arv
Copy link
Contributor

@arv arv commented May 30, 2014

The build.json file did not include DOMTokenList leading to
classList being brokon in 0.3.0

This adds a test that ensures that the list of files is in sync so
that these kind of errors do not happen again.

Fixes #445

The build.json file did not include DOMTokenList leading to
classList being brokon in 0.3.0

This adds a test that ensures that the list of files is in sync so
that these kind of errors do not happen again.

Fixes #445
@arv
Copy link
Contributor Author

arv commented May 30, 2014

@azakus @sjmiles @sorvell

This is a pretty severe bug. It caused 0.3.0 to not work when using the compiled platform.js.

@sorvell
Copy link
Contributor

sorvell commented May 30, 2014

Thx Arv, we'll prioritize doing another release.

On Fri, May 30, 2014 at 9:02 AM, Erik Arvidsson [email protected]
wrote:

@azakus https://github.com/azakus @sjmiles https://github.com/sjmiles
@sorvell https://github.com/sorvell

This is a pretty severe bug. It caused 0.3.0 to not work when using the
compiled platform.js.


Reply to this email directly or view it on GitHub
#448 (comment).

@dfreedm
Copy link
Contributor

dfreedm commented May 30, 2014

Sad we didn't catch this in release testing :(

LGTM

dfreedm added a commit that referenced this pull request May 30, 2014
@dfreedm dfreedm merged commit 2290938 into googlearchive:master May 30, 2014
@arv arv deleted the fix-dom-token-list branch May 30, 2014 19:01
@arv
Copy link
Contributor Author

arv commented May 30, 2014

This caused build failures:

http://build.chromium.org/p/client.polymer/builders/ShadowDOM%20Mac/builds/142

@morethanreal Is the build.json file accessible by the bots?

@dfreedm
Copy link
Contributor

dfreedm commented May 30, 2014

Karma won't serve it automatically

@arv
Copy link
Contributor Author

arv commented May 30, 2014

#449

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants