This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Fix issues where we did not update the renderer after DOM changes #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned - Changing content[select] to more restrictive needs to clean up non matching nodes (we clear the child nodes now) - Changes to fallback content needs to invalate - Adding a content or shadow needs to invalidate wip
|
LGTM |
sjmiles
pushed a commit
that referenced
this pull request
Sep 4, 2013
…validate-renderer Fix issues where we did not update the renderer after DOM changes
arv
deleted the
adding-content-or-shadow-needs-to-invalidate-renderer
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up non matching nodes (we clear the child nodes now)
Fixes #226, #235