This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Make sure we adopt the child that we are inserting #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even in the case where the real dom does not have a parent it is important to do the adoption for the ownerDocument to stay correct.
ghost
assigned 
|
One more please |
|
LGTM |
sorvell
pushed a commit
that referenced
this pull request
Aug 22, 2013
Make sure we adopt the child that we are inserting
dfreedm
added a commit
to googlearchive/platform
that referenced
this pull request
Aug 22, 2013
Somehow, googlearchive/ShadowDOM#223 affected load order tests here. :/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #220
Make sure we adopt the child that we are inserting, even in the case where the real dom does not have a parent it is
important to do the adoption for the ownerDocument to stay correct.
Fixes #216