This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Make attribute dirtying smarter #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Right now the only reflected bindings it handles is More will be needed but I'm not sure we should add them preemptively or not? |
|
LGTM, thx for the fast service! |
sorvell
pushed a commit
that referenced
this pull request
Aug 13, 2013
Make attribute dirtying smarter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now keep track of what attributes the content select depends on and when an attribute is changed we check if the current attribute change would affect one of the attributes the renderer depends on.
Fixes #207