This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Fix accidental global variable #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+1 "use strict"
| @@ -29,7 +29,7 @@ var dynamic = { | |||
| } | |||
| // note: the act of loading kicks the parser, so we use parseDynamic's | |||
| // 2nd argument to control if this added node needs to kick the parser. | |||
| loading = this.shouldLoadNode(n); | |||
| var loading = this.shouldLoadNode(n); | |||
There was a problem hiding this comment.
Good catch, but would you please add this to line 24 instead?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.