This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Fixes for IE #47
Merged
Fixes for IE #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
| } else if (elt.sheet) { | ||
| fakeLoad = true; | ||
| var csr = elt.sheet.cssRules; | ||
| var len = csr.length || 0; |
There was a problem hiding this comment.
This line is weird, probably should be len = csr ? csr.length : 0
Add msMatchesSelector to matches impl check Fix propertyDescriptor for _currentScript Polyfill document.baseURI for IE Remove writable, IE doesn't like it Only need to define baseURI on real document, don't need to keep the prop descriptor around Add heuristic to fake load event for IE Spec says that "load" must always be fired on style element, but IE fails to do so if its resources are either fully text, or the @imports have already been processed asynchornously. http://www.whatwg.org/specs/web-apps/current-work/multipage/semantics.html#the-style-element add MutationObserver and WeakMap to karma serve list Don't try to access CSSRules length if it doesn't exist If we add event listeners first, don't need to call done explicitly
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add MutationObserver polyfill to loader
Add msMatchesSelector to matches impl check
Fix propertyDescriptor for _currentScript
Polyfill document.baseURI for IE
Remove writable, IE doesn't like it
Only need to define baseURI on real document, don't need to keep the prop descriptor around
Add heuristic to fake load event for IE
Spec says that "load" must always be fired on style element, but IE fails to do so if its resources are either fully
text, or the @imports have already been processed asynchornously.
http://www.whatwg.org/specs/web-apps/current-work/multipage/semantics.html#the-style-element
add MutationObserver and WeakMap to karma serve list