Wrap the document, and handle null

[jakemac53]

No description provided.

[jakemac53]

@jmesserly I tested doing this as you suggested yesterday and it makes all the tests pass, ptal.

[jmesserly]

Ah, I was thinking to do it on the Dart side (web_components package). There we know platform.js is included and we have ShadowDOM. We don't make that assumption here.

Last I heard @sorvell is working on a JS fix. I offered to help but he seemed eager to do it :)

[sorvell]

lgtm. I was hoping to wrap (hah!) this into some other refactoring I want to do but it's going to take me a bit longer. This fix seems fine for now.

[jmesserly]

Do we have any concerns about x-tags or other users that consume CustomElements without ShadowDOM polyfill?

[jmesserly]

(Actually even SD polyfill doesn't put wrapIfNeeded on window. That must come from platform.JS)

[sorvell]

There's direct support in the CE polyfill for this (
https://github.com/Polymer/CustomElements/blob/master/src/Observer.js#L220
).

On Wed, Oct 1, 2014 at 10:13 AM, John Messerly [email protected]
wrote:

(Actually even SD polyfill doesn't put wrapIfNeeded on window. That must
come from platform.JS)

—
Reply to this email directly or view it on GitHub
#132 (comment)
.