Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nodejs mono repo post-processor #1470

Closed
wants to merge 6 commits into from
Closed

feat: add nodejs mono repo post-processor #1470

wants to merge 6 commits into from

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Jun 28, 2022

No description provided.

@sofisl sofisl requested a review from a team June 28, 2022 20:57
@snippet-bot
Copy link

snippet-bot bot commented Jun 28, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 26 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

sofisl
sofisl commented Jun 28, 2022
View reviewed changes
synthtool/languages/node_mono_repo.py
@@ -0,0 +1,395 @@
# Copyright 2018 Google LLC
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is important

sofisl
sofisl commented Jun 28, 2022
View reviewed changes
synthtool/gcp/common.py
@@ -326,6 +326,36 @@ def node_library(self, **kwargs) -> Path:

return self._generic_library("node_library", **kwargs)

def node_mono_repo_library(self, relative_dir, **kwargs) -> Path:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are important

sofisl
sofisl commented Jun 28, 2022
View reviewed changes
docker/owlbot/nodejs_mono_repo/Dockerfile
@@ -0,0 +1,55 @@
# Copyright 2021 Google LLC
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is important

docker/owlbot/nodejs_mono_repo/cloudbuild.yaml
@@ -0,0 +1,22 @@
steps:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is important

docker/owlbot/nodejs_mono_repo/entrypoint.sh
@@ -0,0 +1,22 @@
#!/bin/bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is important

tests/test_node_mono_repo.py
@@ -0,0 +1,329 @@
# Copyright 2020 Google LLC
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is important.

@sofisl sofisl changed the title feat: add mono repo post-processor feat: add nodejs mono repo post-processor Jun 28, 2022
@sofisl sofisl mentioned this pull request Jun 28, 2022
Merged
@sofisl sofisl closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

@chingor13 chingor13 Awaiting requested review from chingor13 chingor13 is a code owner

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sofisl