Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Oct 20, 2021

PR #1246 added ability to detect versions recursively when detect_versions() is called, however we're seeing erroneous versions detected in python-webrisk here.

I've updated the code to stop searching subdirectories if versions are found in the parent directory. I've also added a test to confirm the behaviour.

With the code in #1246, the following versions are detected.

webrisk_v1
webrisk_v1beta1
web_risk_service_v1_beta1 <- this is erroneously detected, and it is actually a service under webrisk_v1beta1

With the code in this PR, the following versions are detected

webrisk_v1
webrisk_v1beta1

@parthea parthea force-pushed the fix-erroneous-versions-detected branch from 52eaa92 to 7f76b37 Compare October 20, 2021 09:24
@parthea
Copy link
Contributor Author

parthea commented Oct 20, 2021

I tested the post processor in this commit in a PR on python-webrisk and it produced the correct result.

@parthea
Copy link
Contributor Author

parthea commented Oct 20, 2021

I also tested the post processor in this commit in a PR on python-phishingprotection and it produced the correct result.

@parthea parthea merged commit aac3331 into master Oct 20, 2021
@parthea parthea deleted the fix-erroneous-versions-detected branch October 20, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants