deps: Upgrade Google Http Java Client to v2.0.2 #3946
Conversation
Summary of ChangesHello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating a core dependency, the Google HTTP Java Client, to its latest version, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request proposes to upgrade the google-http-client dependency from version 1.47.1 to 2.0.2. This is a major version upgrade. My review has identified a critical issue with this change. The target version 2.0.2 for com.google.http-client:google-http-client-bom does not appear to exist in public Maven repositories, which will cause the build to fail. Furthermore, even if the version existed, google-http-client 2.x versions would likely require Java 11 or newer, but this project is configured to compile for Java 8. This would lead to runtime errors. Therefore, this upgrade cannot be merged as is.
| <grpc.version>1.71.0</grpc.version> | ||
| <google.auth.version>1.39.1</google.auth.version> | ||
| <google.http-client.version>1.47.1</google.http-client.version> | ||
| <google.http-client.version>2.0.2</google.http-client.version> |
There was a problem hiding this comment.
This version upgrade is problematic for two main reasons:
-
Non-existent version: The version
2.0.2forcom.google.http-client:google-http-client-bomdoes not seem to be published to Maven Central. This will cause a build failure due to an unresolved dependency. The latest available version for this artifact is1.47.1. -
Java version incompatibility: This is a major version upgrade. Google client libraries with a 2.x version typically require Java 11 or higher. This project is configured with
<maven.compiler.release>8</maven.compiler.release>, targeting Java 8. Using a Java 11+ library in a Java 8 project would result in ajava.lang.UnsupportedClassVersionErrorat runtime.
Due to these critical issues, this version should be reverted to 1.47.1.
| <google.http-client.version>2.0.2</google.http-client.version> | |
| <google.http-client.version>1.47.1</google.http-client.version> |
|
|
🤖 I have created a release *beep* *boop* --- <details><summary>2.63.0</summary> ## [2.63.0](v2.62.3...v2.63.0) (2025-10-16) ### Features * **librariangen:** add bazel package ([#3940](#3940)) ([feabef3](feabef3)) * **librariangen:** add execv package ([#3932](#3932)) ([f6b0b47](f6b0b47)) * **librariangen:** add protoc package ([#3935](#3935)) ([598de06](598de06)) * **librariangen:** add request package ([#3933](#3933)) ([fe44aed](fe44aed)) * **librariangen:** scaffold Java language container for Librarian ([#3926](#3926)) ([29d188d](29d188d)) ### Dependencies * Bump errorprone-annotations to v2.42.0 ([8d6c1f9](8d6c1f9)) * Bump guava to v33.5.0 ([8d6c1f9](8d6c1f9)) * Bump j2objc-annotations to v3.1 ([8d6c1f9](8d6c1f9)) * update google auth library dependencies to v1.40.0 ([#3945](#3945)) ([1d74663](1d74663)) * Upgrade Google Http Java Client to v2.0.2 ([#3946](#3946)) ([7fb4f15](7fb4f15)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
2 participants
No description provided.