Skip to content

fix: Update generated tests to use Message instead of AbstractMessage #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

fix: Update generated tests to use Message instead of AbstractMessage #3729

wants to merge 12 commits into from

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Apr 1, 2025 •
edited
Loading

Fixes #3891

Error message during compilation:

incompatible types: com.google.protobuf.Empty cannot be converted to com.google.protobuf.AbstractMessage

@product-auto-label product-auto-label bot added size: s Pull request size is small. size: m Pull request size is medium. size: l Pull request size is large. and removed size: s Pull request size is small. size: m Pull request size is medium. size: l Pull request size is large. labels Apr 1, 2025
@lqiu96 lqiu96 changed the title chore: Update gax-grpc's testlib refrences to use Message fix: Update generated tests to use Message instead of AbstractMessage Apr 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lqiu96
Copy link
Member Author

lqiu96 commented Apr 2, 2025

Error in downstream CI logs:

/workspace/google-cloud-java/java-kms/google-cloud-kms/src/test/java/com/google/cloud/kms/v1/MockLocations.java:[40,3] method does not override or implement a method from a supertype

This error is expected as it requires downstream libraries to be updated with the generator changes. There are some breaking changes in the testlib.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lqiu96 lqiu96 mentioned this pull request Apr 3, 2025
Open
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. size: l Pull request size is large. and removed size: l Pull request size is large. size: xl Pull request size is extra large. labels Aug 21, 2025
@lqiu96 lqiu96 force-pushed the message-testlib-jars branch from be34d77 to 9ccd02b Compare August 27, 2025 18:38
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Aug 27, 2025
@lqiu96 lqiu96 force-pushed the message-testlib-jars branch from 9ccd02b to 0af7c94 Compare August 27, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the generated tests to reference Message instead of AbstractMessage

2 participants

@lqiu96 @cloud-java-bot