Skip to content

ci: Update protobuf compatibility ci to default to 4.29.0 #3699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 2 commits into from
Mar 13, 2025
Merged

ci: Update protobuf compatibility ci to default to 4.29.0 #3699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc86b13
ci: Update protobuf compatibility ci to defualt to 4.29.0
lqiu96 Mar 13, 2025
0d9fd20
Merge branch 'main' into protobuf-ci-4.29.0
lqiu96 Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/downstream_protobuf_compatibility_check_nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- java-storage-nio
# Default Protobuf-Java versions to use are specified here. Without this, the nightly workflow won't know
# which values to use and would resolve to ''.
protobuf-version: ${{ fromJSON(format('[{0}]', inputs.protobuf_runtime_versions || '"3.25.5","4.28.3"')) }}
protobuf-version: ${{ fromJSON(format('[{0}]', inputs.protobuf_runtime_versions || '"3.25.5","4.29.0"')) }}
Copy link
Contributor

@blakeli0 blakeli0 Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a future enhancement: we can grab the version from java-cloud-bom so that we don't forget to update it here.

Copy link
Member Author

@lqiu96 lqiu96 Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I can create a follow up ticket for this

steps:
- name: Checkout sdk-platform-java repo
uses: actions/checkout@v4
Expand Down
Loading