Skip to content

chore: Update README and CI with the new name of showcase module. #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

chore: Update README and CI with the new name of showcase module. #3680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8b612f
chore: Update README and CI with the new name of showcase module.
blakeli0 Mar 7, 2025
319f2ff
Update ci.yaml
blakeli0 Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,7 @@ jobs:
- name: Install sdk-platform-java and showcase to local maven repository
run: |
mvn install -B -ntp -T 1C -DskipTests
# change to `cd java-showcase` once https://github.com/googleapis/sdk-platform-java/pull/3568/ is merged
cd showcase
cd java-showcase
mvn install -B -ntp -T 1C -DskipTests
SHOWCASE_CLIENT_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
echo "SHOWCASE_CLIENT_VERSION=$SHOWCASE_CLIENT_VERSION" >> "$GITHUB_ENV"
Expand Down
4 changes: 2 additions & 2 deletions java-showcase/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ update to a compatible client version in `./WORKSPACE`.

```shell
# Install the showcase server version defined in gapic-showcase/pom.xml
cd showcase
cd java-showcase
go install github.com/googleapis/gapic-showcase/cmd/gapic-showcase@v"$(cd gapic-showcase;mvn help:evaluate -Dexpression=gapic-showcase.version -q -DforceStdout |sed 's/\x1b\[[0-9;]*m//g')"
PATH=$PATH:`go env GOPATH`/bin
gapic-showcase --help
Expand Down Expand Up @@ -67,7 +67,7 @@ Open a new terminal window in the root project directory.
This step does not require Docker.

```shell
cd showcase
cd java-showcase
mvn verify -P enable-integration-tests
```

Expand Down
Loading