-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable selective generation based on service config include list #3323
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passed for 'gapic-generator-java-root'Issues Measures |
Quality Gate passed for 'java_showcase_integration_tests'Issues Measures |
} | ||
List<String> includeMethodsList = | ||
librarySettingsList | ||
.get(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from in-person review: Add comment about .get(0)
@@ -101,4 +101,14 @@ void generateGrpcServiceStubClass_callableNameType() { | |||
Assert.assertGoldenClass(this.getClass(), clazz, "GrpcCallableNameTypeStub.golden"); | |||
Assert.assertEmptySamples(clazz.samples()); | |||
} | |||
|
|||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from in-person review: remove golden test
following changes in client.proto that propagated to
ClientProto.java
(pr), apply changes from poc pr (#3129).For context: go/selective-api-gen-java-one-pager, b/356380016