Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

Reverts a temporary solution from #1791 (comment) that excludes j2objc-annotations brought by protobuf-java-util which has a differing version.

With protobuf 24.3, this should not be necessary anymore

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 22, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diegomarquezp diegomarquezp marked this pull request as ready for review September 22, 2023 18:17
@diegomarquezp diegomarquezp requested a review from a team as a code owner September 22, 2023 18:17
@diegomarquezp diegomarquezp added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 22, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 22, 2023
@diegomarquezp diegomarquezp merged commit 97bf9ed into main Sep 22, 2023
@diegomarquezp diegomarquezp deleted the revert-j2objc-exclusion branch September 22, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants