fix note for default unary rpc

googleapis · Nov 18, 2020 · 0a5b153 · 0a5b153
1 parent 5b7a57c
commit 0a5b153
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 22 deletions.
diff --git a/src/main/java/com/google/api/generator/gapic/composer/SampleCodeHelperComposer.java b/src/main/java/com/google/api/generator/gapic/composer/SampleCodeHelperComposer.java
@@ -95,7 +95,7 @@ private static TryCatchStatement composeUnaryRpcDefaultMethodSampleCode(
             "Note: Not Implement yet. Holder for unary %s rpc method sample code.",
             (!method.hasLro() && !method.isPaged()
                 ? "default"
-                : (method.hasLro() ? "lro" : "paged")));
+                : (method.hasLro() ? "lro default" : "paged default")));
     return TryCatchStatement.builder()
         .setTryResourceExpr(assignClientVariableWithCreateMethodExpr(clientType))
         .setTryBody(Arrays.asList(createLineCommentStatement(content)))

diff --git a/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClient.golden b/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClient.golden
@@ -326,7 +326,7 @@ public class EchoClient implements BackgroundResource {
    *
    * <pre>{@code
    * try (EchoClient echoClient = EchoClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *
@@ -392,7 +392,7 @@ public class EchoClient implements BackgroundResource {
    *
    * <pre>{@code
    * try (EchoClient echoClient = EchoClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary lro rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary lro default rpc method sample code.
    * }
    * }</pre>
    *

diff --git a/src/test/java/com/google/api/generator/gapic/composer/goldens/IdentityClient.golden b/src/test/java/com/google/api/generator/gapic/composer/goldens/IdentityClient.golden
@@ -360,7 +360,7 @@ public class IdentityClient implements BackgroundResource {
    *
    * <pre>{@code
    * try (IdentityClient identityClient = IdentityClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *

diff --git a/test/integration/goldens/asset/AssetServiceClient.java b/test/integration/goldens/asset/AssetServiceClient.java
@@ -170,7 +170,7 @@ public final OperationsClient getOperationsClient() {
    *
    * <pre>{@code
    * try (AssetServiceClient assetServiceClient = AssetServiceClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary lro rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary lro default rpc method sample code.
    * }
    * }</pre>
    *
@@ -644,7 +644,7 @@ public final SearchAllResourcesPagedResponse searchAllResources(
    *
    * <pre>{@code
    * try (AssetServiceClient assetServiceClient = AssetServiceClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *
@@ -750,7 +750,7 @@ public final SearchAllIamPoliciesPagedResponse searchAllIamPolicies(String scope
    *
    * <pre>{@code
    * try (AssetServiceClient assetServiceClient = AssetServiceClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *

diff --git a/test/integration/goldens/logging/ConfigServiceV2Client.java b/test/integration/goldens/logging/ConfigServiceV2Client.java
@@ -295,7 +295,7 @@ public final ListBucketsPagedResponse listBuckets(String parent) {
    *
    * <pre>{@code
    * try (ConfigServiceV2Client configServiceV2Client = ConfigServiceV2Client.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *
@@ -533,7 +533,7 @@ public final ListSinksPagedResponse listSinks(String parent) {
    *
    * <pre>{@code
    * try (ConfigServiceV2Client configServiceV2Client = ConfigServiceV2Client.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *
@@ -1254,7 +1254,7 @@ public final ListExclusionsPagedResponse listExclusions(String parent) {
    *
    * <pre>{@code
    * try (ConfigServiceV2Client configServiceV2Client = ConfigServiceV2Client.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *

diff --git a/test/integration/goldens/logging/LoggingServiceV2Client.java b/test/integration/goldens/logging/LoggingServiceV2Client.java
@@ -466,7 +466,7 @@ public final ListLogEntriesPagedResponse listLogEntries(
    *
    * <pre>{@code
    * try (LoggingServiceV2Client loggingServiceV2Client = LoggingServiceV2Client.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *
@@ -511,7 +511,7 @@ public final ListLogEntriesPagedResponse listLogEntries(ListLogEntriesRequest re
    *
    * <pre>{@code
    * try (LoggingServiceV2Client loggingServiceV2Client = LoggingServiceV2Client.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *
@@ -683,7 +683,7 @@ public final ListLogsPagedResponse listLogs(String parent) {
    *
    * <pre>{@code
    * try (LoggingServiceV2Client loggingServiceV2Client = LoggingServiceV2Client.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *

diff --git a/test/integration/goldens/logging/MetricsServiceV2Client.java b/test/integration/goldens/logging/MetricsServiceV2Client.java
@@ -197,7 +197,7 @@ public final ListLogMetricsPagedResponse listLogMetrics(String parent) {
    *
    * <pre>{@code
    * try (MetricsServiceV2Client metricsServiceV2Client = MetricsServiceV2Client.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *

diff --git a/test/integration/goldens/redis/CloudRedisClient.java b/test/integration/goldens/redis/CloudRedisClient.java
@@ -257,7 +257,7 @@ public final ListInstancesPagedResponse listInstances(String parent) {
    *
    * <pre>{@code
    * try (CloudRedisClient cloudRedisClient = CloudRedisClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary paged rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary paged default rpc method sample code.
    * }
    * }</pre>
    *
@@ -502,7 +502,7 @@ public final OperationFuture<Instance, OperationMetadata> createInstanceAsync(
    *
    * <pre>{@code
    * try (CloudRedisClient cloudRedisClient = CloudRedisClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary lro rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary lro default rpc method sample code.
    * }
    * }</pre>
    *
@@ -599,7 +599,7 @@ public final OperationFuture<Instance, OperationMetadata> updateInstanceAsync(
    *
    * <pre>{@code
    * try (CloudRedisClient cloudRedisClient = CloudRedisClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary lro rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary lro default rpc method sample code.
    * }
    * }</pre>
    *
@@ -701,7 +701,7 @@ public final OperationFuture<Instance, OperationMetadata> upgradeInstanceAsync(
    *
    * <pre>{@code
    * try (CloudRedisClient cloudRedisClient = CloudRedisClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary lro rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary lro default rpc method sample code.
    * }
    * }</pre>
    *
@@ -779,7 +779,7 @@ public final OperationFuture<Instance, OperationMetadata> importInstanceAsync(
    *
    * <pre>{@code
    * try (CloudRedisClient cloudRedisClient = CloudRedisClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary lro rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary lro default rpc method sample code.
    * }
    * }</pre>
    *
@@ -867,7 +867,7 @@ public final OperationFuture<Instance, OperationMetadata> exportInstanceAsync(
    *
    * <pre>{@code
    * try (CloudRedisClient cloudRedisClient = CloudRedisClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary lro rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary lro default rpc method sample code.
    * }
    * }</pre>
    *
@@ -979,7 +979,7 @@ public final OperationFuture<Instance, OperationMetadata> failoverInstanceAsync(
    *
    * <pre>{@code
    * try (CloudRedisClient cloudRedisClient = CloudRedisClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary lro rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary lro default rpc method sample code.
    * }
    * }</pre>
    *
@@ -1069,7 +1069,7 @@ public final OperationFuture<Empty, OperationMetadata> deleteInstanceAsync(Strin
    *
    * <pre>{@code
    * try (CloudRedisClient cloudRedisClient = CloudRedisClient.create()) {
-   *   // Note: Not Implement yet. Holder for unary lro rpc method sample code.
+   *   // Note: Not Implement yet. Holder for unary lro default rpc method sample code.
    * }
    * }</pre>
    *