Skip to content

Conversation

@Pulkit0110
Copy link
Member

Changing the gapic directory from storage_v2 to _storage_v2 so that it acts as a private folder.

@Pulkit0110 Pulkit0110 requested review from a team as code owners August 12, 2025 08:55
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Aug 12, 2025
@chalmerlowe
Copy link
Contributor

chalmerlowe commented Aug 12, 2025

@Pulkit0110

I am curious:

  • What are our reasons for suggesting this change to a private folder?
  • Are there benefits to this that you see?
  • Are there disadvantages to leaving the folder as is?

My understanding has always been that the folder names for all the GAPIC generated code are automatically created by the GAPIC generator and customarily use the format google/cloud/{packagename_v#}.

If that is the case, then changing the format here may not be a lasting change next time the GAPIC generated code gets rebuilt.

Relatedly, there are 60+ references to storage_v2 in this code base alone (especially in tests, etc). For example: from google.cloud import storage_v2

If the change to a new folder naming convention is approved, should those also be changed to _storage_v2?

Any insight you can offer is appreciated.

@danielduhh
Copy link
Contributor

@chalmerlowe We're not exposing the gapic directly to customers -- thus moving this to a private folder makes sense. The plan is to write a veneer over the GAPIC client. See details here: go/storage-python-grpc & go/bidi-reads-py-sdk

@Pulkit0110 Pulkit0110 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2025
@Pulkit0110 Pulkit0110 merged commit 04b01ed into googleapis:main Aug 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants