Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to main branch #549

Merged
merged 3 commits into from
Aug 31, 2021
Merged

chore: migrate to main branch #549

merged 3 commits into from
Aug 31, 2021

Conversation

dandhlee
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Unsure how to update https://github.com/googleapis/python-spanner/blob/master/pylint.config.py#L25-L28, filed #548 to keep track of it.

Fixes #547 🦕

@dandhlee dandhlee requested a review from parthea August 30, 2021 20:26
@dandhlee dandhlee requested a review from a team as a code owner August 30, 2021 20:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Aug 30, 2021
@dandhlee dandhlee mentioned this pull request Aug 30, 2021
Closed
@larkee larkee added the automerge Merge the pull request once unit tests and other checks pass. label Aug 31, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit cfd8bc2 into main Aug 31, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the to_main branch August 31, 2021 05:58
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

@tseaver tseaver tseaver approved these changes

@parthea parthea Awaiting requested review from parthea

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to main branch
3 participants
@dandhlee @tseaver @larkee