Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/spanner_dbapi/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ def connect(
database = None
if database_id:
database = instance.database(database_id, pool=pool)
conn = Connection(instance, database)
conn = Connection(instance, database, **kwargs)
if pool is not None:
conn._own_pool = False

Expand Down
13 changes: 13 additions & 0 deletions tests/unit/spanner_dbapi/test_connect.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,16 @@ def test_w_credential_file_path(self, mock_client):
client_info = factory.call_args_list[0][1]["client_info"]
self.assertEqual(client_info.user_agent, USER_AGENT)
self.assertEqual(client_info.python_version, PY_VERSION)

def test_with_kwargs(self, mock_client):
from google.cloud.spanner_dbapi import connect
from google.cloud.spanner_dbapi import Connection

client = mock_client.return_value
instance = client.instance.return_value
database = instance.database.return_value

connection = connect(INSTANCE, DATABASE, ignore_transaction_warnings=True)

self.assertIsInstance(connection, Connection)
self.assertTrue(connection._ignore_transaction_warnings)
Loading