chore(x-goog-spanner-request-id): plug in functionality after test scaffolding #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
odeke-em
force-pushed
the
x-goog-spanner-request-id-add-functionality-after-scaffolding
branch
from
9c76b52 to
f82ef0c
Compare
odeke-em
force-pushed
the
x-goog-spanner-request-id-add-functionality-after-scaffolding
branch
2 times, most recently
from
9b9a263 to
b8b1591
Compare
product-auto-label
bot
added
size: xl
…affolding This change chops down the load of the large changes for x-goog-spanner-request-id. It depends on PR googleapis#1366 and should only be merged after that PR. Updates googleapis#1261 Requires PR googleapis#1366
odeke-em
force-pushed
the
x-goog-spanner-request-id-add-functionality-after-scaffolding
branch
from
d513594 to
2c44ec8
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
@rahul2393 @olavloite @harshachinta @sakthivelmanii kindly help run the bots. Thank you. |
olavloite
reviewed
May 14, 2025
odeke-em
force-pushed
the
x-goog-spanner-request-id-add-functionality-after-scaffolding
branch
2 times, most recently
from
1b0d745 to
c8da8d8
Compare
Contributor
Author
|
@olavloite thank you for the first round of review. I have addressed it, please take another look and kindly help me re-run the bots. |
odeke-em
force-pushed
the
x-goog-spanner-request-id-add-functionality-after-scaffolding
branch
from
c8da8d8 to
6f1ffff
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
approved these changes
May 17, 2025
sakthivelmanii
approved these changes
May 17, 2025
odeke-em
deleted the
x-goog-spanner-request-id-add-functionality-after-scaffolding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change chops down the load of the large changes for x-goog-spanner-request-id. It depends on PR #1366 and should only be merged after that PR.
Updates #1261
Requires PR #1366