chore(x-goog-spanner-request-id): implement request_id generation and propagation 1/3 #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
odeke-em
force-pushed
the
x-goog-spanner-request-id-piecemeal-1
branch
from
1ac1db3 to
f7f21a0
Compare
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Apr 30, 2025
This change commits the scaffolding for which testing will be used. This is a carve out of PRs googleapis#1264 and googleapis#1364, meant to make those changes lighter and much easier to review then merge. Updates googleapis#1261
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Apr 30, 2025
This change commits the scaffolding for which testing will be used. This is a carve out of PRs googleapis#1264 and googleapis#1364, meant to make those changes lighter and much easier to review then merge. Updates googleapis#1261
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
Apr 30, 2025
This change commits the scaffolding for which testing will be used. This is a carve out of PRs googleapis#1264 and googleapis#1364, meant to make those changes lighter and much easier to review then merge. Updates googleapis#1261
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this pull request
May 2, 2025
This change commits the scaffolding for which testing will be used. This is a carve out of PRs googleapis#1264 and googleapis#1364, meant to make those changes lighter and much easier to review then merge. Updates googleapis#1261
olavloite
pushed a commit
that referenced
this pull request
May 7, 2025
* chore(x-goog-request-id): commit testing scaffold This change commits the scaffolding for which testing will be used. This is a carve out of PRs #1264 and #1364, meant to make those changes lighter and much easier to review then merge. Updates #1261 * Use guard to keep x-goog-request-id interceptor docile in tests until activation later * AtomicCounter update * Remove duplicate unavailable_status that had been already committed into main
… propagation 1/3 Generates a request_id that is then injected inside metadata that's sent over to the Cloud Spanner backend. Officially inject the first set of x-goog-spanner-request-id values into header metadata Add request-id interceptor to use in asserting tests Wrap Snapshot methods with x-goog-request-id metadata injector Updates googleapis#1261
odeke-em
force-pushed
the
x-goog-spanner-request-id-piecemeal-1
branch
from
f7f21a0 to
0b8003e
Compare
|
No longer needed as I mailed out smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates a request_id that is then injected inside metadata that's sent over to the Cloud Spanner backend.
Officially inject the first set of x-goog-spanner-request-id values into header metadata Add request-id interceptor to use in asserting tests Wrap Snapshot methods with x-goog-request-id metadata injector
Updates #1261