-
Notifications
You must be signed in to change notification settings - Fork 101
feat: snapshot isolation #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: snapshot isolation #1318
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dcaf26f
feat: snapshot isolation
surbhigarg92 e288f38
test and refactoring
surbhigarg92 0e7b98a
tests
surbhigarg92 3bd8cf9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] a370eae
review comments
surbhigarg92 17c7b4f
review comments and tests
surbhigarg92 3dad2f2
lint
surbhigarg92 840626b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 20c8e81
dataclass for default transaction options
surbhigarg92 099ae10
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 7cad765
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] a354f4a
proto merge for transaction options
surbhigarg92 c87d2a3
failed test cases
surbhigarg92 5b40f76
review comments
surbhigarg92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we clearly call out that this is only for r/w transactions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to keep it flexible for all types of transaction options. For example, if we add
exclude_txn_from_change_streamsto the default transaction options, it should apply to both RW and PDML. To handle this, we can introduce another private property_defaultPDMTransactionOptionswithin theDefaultTransactionOptionsclass, whereexclude_txn_from_change_streamswill be set.